Re: [PATCH] staging: lustre: Use 'kvfree()' for memory allocated by 'kvzalloc()'

From: NeilBrown
Date: Sat May 12 2018 - 17:32:07 EST


On Sat, May 12 2018, Christophe JAILLET wrote:

> 'buf' is allocated with 'kvzalloc()'. 'kvfree()' must be used to free it.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Reviewed-by: NeilBrown <neilb@xxxxxxxx>

Thanks.
We could possible add:
Fixes: 11c647caf74b ("staging: lustre: obdclass: variable llog chunk size")

just for completeness.

NeilBrown

> ---
> drivers/staging/lustre/lustre/obdclass/llog.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/llog.c b/drivers/staging/lustre/lustre/obdclass/llog.c
> index 693e1129f1f9..5e04d133b596 100644
> --- a/drivers/staging/lustre/lustre/obdclass/llog.c
> +++ b/drivers/staging/lustre/lustre/obdclass/llog.c
> @@ -385,7 +385,7 @@ static int llog_process_thread(void *arg)
> if (cd)
> cd->lpcd_last_idx = last_called_index;
>
> - kfree(buf);
> + kvfree(buf);
> lpi->lpi_rc = rc;
> return 0;
> }
> --
> 2.17.0

Attachment: signature.asc
Description: PGP signature