Re: [PATCH] brd: Mark as non-rotational

From: SeongJae Park
Date: Wed May 09 2018 - 00:07:56 EST


I'm sending this mail for another chance of review.


Thanks,
SeongJae Park
On Thu, May 3, 2018 at 6:53 PM SeongJae Park <sj38.park@xxxxxxxxx> wrote:

> This commit sets QUEUE_FLAG_NONROT and clears up QUEUE_FLAG_ADD_RANDOM
> to mark the ramdisks as non-rotational device.

> Signed-off-by: SeongJae Park <sj38.park@xxxxxxxxx>
> ---
> drivers/block/brd.c | 4 ++++
> 1 file changed, 4 insertions(+)

> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index 66cb0f857f64..39c5b90cc187 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -402,6 +402,10 @@ static struct brd_device *brd_alloc(int i)
> set_capacity(disk, rd_size * 2);
> disk->queue->backing_dev_info->capabilities |=
BDI_CAP_SYNCHRONOUS_IO;

> + /* Tell the block layer that this is not a rotational device */
> + blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue);
> + blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, disk->queue);
> +
> return brd;

> out_free_queue:
> --
> 2.13.0