Re: [PATCH v2] x86/boot/64/clang: Use fixup_pointer() to access '__supported_pte_mask'

From: Kirill A. Shutemov
Date: Tue May 08 2018 - 17:44:54 EST


On Tue, May 08, 2018 at 04:28:29PM +0000, Alexander Potapenko wrote:
> @@ -196,7 +204,8 @@ unsigned long __head __startup_64(unsigned long physaddr,
>
> pmd_entry = __PAGE_KERNEL_LARGE_EXEC & ~_PAGE_GLOBAL;
> /* Filter out unsupported __PAGE_KERNEL_* bits: */
> - pmd_entry &= __supported_pte_mask;
> + mask_ptr = (pteval_t *)fixup_pointer(&__supported_pte_mask, physaddr);

Do we really need the cast here?

--
Kirill A. Shutemov