Re: [PATCH 2/2] tools/testing/selftests/x86: fix error: conflicting types for 'pkey_get|pkey_set'

From: Dave Hansen
Date: Tue May 08 2018 - 12:30:15 EST


On 05/08/2018 02:14 AM, Li Zhijian wrote:
> -u32 pkey_get(int pkey, unsigned long flags)
> +u32 _pkey_get(int pkey, unsigned long flags)
> {
> u32 mask = (PKEY_DISABLE_ACCESS|PKEY_DISABLE_WRITE);
> u32 pkru = __rdpkru();
> @@ -422,7 +426,7 @@ u32 pkey_get(int pkey, unsigned long flags)
> return masked_pkru;
> }

I'm not a huge fan of random underscores for undocumented reasons. But,
oh well.

Acked-by: Dave Hansen <dave.hansen@xxxxxxxxx>