Re: [kvmtool PATCH 21/17] kvmtool: arm: Add support for creating VM with PA size

[Suzuki K Poulose]

On 30/04/18 15:17, Julien Grall wrote:
> Hi,
>
> On 27/03/18 14:15, Suzuki K Poulose wrote:
> > diff --git a/arm/kvm.c b/arm/kvm.c
> > index 5701d41..a9a9140 100644
> > --- a/arm/kvm.c
> > +++ b/arm/kvm.c
> > @@ -11,6 +11,8 @@
> > Â #include <linux/kvm.h>
> > Â #include <linux/sizes.h>
> > +unsigned long kvm_arm_type;
> > +
> > Â struct kvm_ext kvm_req_ext[] = {
> > ÂÂÂÂÂ { DEFINE_KVM_EXT(KVM_CAP_IRQCHIP) },
> > ÂÂÂÂÂ { DEFINE_KVM_EXT(KVM_CAP_ONE_REG) },
> > @@ -18,6 +20,25 @@ struct kvm_ext kvm_req_ext[] = {
> > ÂÂÂÂÂ { 0, 0 },
> > Â };
> > +#ifndef KVM_ARM_GET_MAX_VM_PHYS_SHIFT
> > +#define KVM_ARM_GET_MAX_VM_PHYS_SHIFTÂÂÂÂÂÂÂ _IO(KVMIO, 0x0a)
> > +#endif
> > +
> > +void kvm__arch_init_hyp(struct kvm *kvm)
> > +{
> > +ÂÂÂ unsigned max_ipa;
> > +
> > +ÂÂÂ max_ipa = ioctl(kvm->sys_fd, KVM_ARM_GET_MAX_VM_PHYS_SHIFT);
> > +ÂÂÂ if (max_ipa < 0)
>
> Another issues spotted while doing some testing. This will always be false because max_ipa is unsigned.
>
> I think we want to turn max_ipa to signed.

Good catch. I will fix it.

Cheers
Suzuki