RE: [PATCH 5/5] X86: Hyper-V: Consolidate the allocation of the hypercall input page

From: Thomas Gleixner
Date: Fri Apr 27 2018 - 06:58:55 EST


On Fri, 27 Apr 2018, KY Srinivasan wrote:

>
>
> > -----Original Message-----
> > From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Sent: Thursday, April 26, 2018 3:24 PM
> > To: KY Srinivasan <kys@xxxxxxxxxxxxx>
> > Cc: x86@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux-
> > kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx;
> > apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx; hpa@xxxxxxxxx; Stephen
> > Hemminger <sthemmin@xxxxxxxxxxxxx>; Michael Kelley (EOSG)
> > <Michael.H.Kelley@xxxxxxxxxxxxx>; vkuznets@xxxxxxxxxx
> > Subject: Re: [PATCH 5/5] X86: Hyper-V: Consolidate the allocation of the
> > hypercall input page
> >
> > On Wed, 25 Apr 2018, kys@xxxxxxxxxxxxxxxxx wrote:
> >
> > > From: "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>
> > >
> > > Consolidate the allocation of the hypercall input page.
> >
> > Again. You can provide the new way of allocation first, then you don't have
> > to add code first in order to remove it later again.
>
> I have implemented the new way upfront for the new code - the IPI code
> [PATCH 2/5] X86: Hyper-V: Enable IPI enlightenments.
> What I am doing here using that infrastructure for the TLB flush enlightenments
> and getting rid of unnecessary code.

Ok. I maybe misread it, but a bit more elaborate change log might help to
avoid that.

Thanks,

tglx