Re: [PATCH] USB: serial: option: adding support for ublox R410M

From: Johan Hovold
Date: Thu Apr 26 2018 - 12:12:43 EST


On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote:
> On 4/26/2018 18:39, Lars Melin wrote:
> > On 4/26/2018 18:19, Bjørn Mork wrote:
> >> Anyway, Qualcomm based designs are definitely handled by both drivers.
> >> Using qcserial only makes sense if the interface layout matches one of
> >> the defined shared schemes, which currently are:
> >>
> >>     QCSERIAL_G2K = 0,    /* Gobi 2000 */
> >>     QCSERIAL_G1K = 1,    /* Gobi 1000 */
> >>     QCSERIAL_SWI = 2,    /* Sierra Wireless */
> >>     QCSERIAL_HWI = 3,    /* Huawei */
> >
> > It seems to me that this Quectel device matches the interface layout for
> > Gobi1K:
> >
> >          * Gobi 1K USB layout:
> >          * 0: DM/DIAG (use libqcdm from ModemManager for communication)
> >          * 1: serial port (doesn't respond)
> >          * 2: AT-capable modem port
> >          * 3: QMI/net
> >          */

> Ublox, not Quectel..

Yeah, but qcserial appears to select a different altsetting for the DM
port for Gobi 1000, an altsetting which this particular device does not
have.

I didn't re-read the full thread I referred to earlier, but I think in
it, Dan mentioned Gobi 1000 device requiring firmware to be loaded too.

So if it's not a G1K device, we probably shouldn't be using qcserial
even if the interface layout happens to match.

Thanks,
Johan