Re: [PATCH v5 2/3] pinctrl: bcm2835: Add support for generic pinctrl binding

From: Linus Walleij
Date: Thu Apr 26 2018 - 08:24:38 EST


On Wed, Apr 11, 2018 at 6:58 AM, Matheus Castello
<matheus@xxxxxxxxxxxxxxx> wrote:

> To keep driver up to date we add generic pinctrl binding support, which covers
> the features used in this driver and has additional node properties that this
> SoC has compatibility, so enabling future implementations of these properties
> without the need to create new node properties in the device trees.
>
> The logic of this change maintain the old brcm legacy binding support in order
> to keep the ABI stable.
>
> Signed-off-by: Matheus Castello <matheus@xxxxxxxxxxxxxxx>

Looking good, just need to address Stefan's comments.

(I already merged patch 1 so you do not need to resend this.)

The driver is kind of part of what Stefan and Eric maintains but
it would be nice to get a nod from Stephen Warren as well
as in my mind he is also maintainer for this. Please include him
on subsequent postings as well.

Yours,
Linus Walleij