Re: [PATCH 2/3] dt-bindings: power: supply: qcom_bms: Add bindings
From: Linus Walleij
Date: Thu Apr 26 2018 - 07:40:15 EST
On Sat, Apr 7, 2018 at 3:46 PM, Craig Tatlor <ctatlor97@xxxxxxxxx> wrote:
This is very interesting bindings!
> Add bindings for the Qualcomm battery measurement system.
>
> Signed-off-by: Craig Tatlor <ctatlor97@xxxxxxxxx>
Please expand on acronyms as requested by Rob.
> +Required properties:
> +- compatible: Should contain "qcom,pm8941-bms".
> +- reg: Specifies the SPMI address and length of the
> + controller's registers.
> +- interrupts: OCV threshold interrupt.
> +- io-channels: Should contain IIO channel specifier for the
> + ADC channel that reports battery temperature.
> +- io-channel-names: Should contain "temp".
These are fine (and good) as bindings go.
> +- qcom,fcc-temp-legend: An array containing the temperature, in degC,
> + for each column of the FCC lookup table.
> +- qcom,fcc-lut: An array of FCC values in mah, one entry for each
> + temperature defined in in qcom,fcc-temp-legend.
> +- qcom,ocv-temp-legend: An array containing the temperature, in degC,
> + for each column of the OCV lookup table.
> +- qcom,ocv-capacity-legend: An array containing the capacity for each
> + row of the OCV lookup table.
> +- qcom,ocv-lut: An array of OCV values in mV, one entry for each
> + capacity defined in qcom,ocv-capacity-legend.
I wonder if these are really Qualcomm-specific.
Can't we just cut the "qcom,*" prefix from all and simply define
these lookup tables in a way (with units) that makes sense to all
kinds of battery capacities?
Maybe spell them out though and avoid the abbreviations.
Just put those in the already existing
Documentation/devicetree/bindings/power/supply/battery.txt
so others can reuse them from there.
You will see that those bindings does not abbreviate but
spells out the natural sciences definitions to it's a bliss to
read for everyone.
Yours,
Linus Walleij