Re: [PATCH] mkiss: remove redundant check for len > 0

From: David Miller
Date: Wed Apr 25 2018 - 14:13:20 EST


From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Wed, 25 Apr 2018 11:43:07 +0100

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The check for len > 0 is always true and hence is redundant as
> this check is already being made to execute the code inside the
> while-loop. Hence it is redundant and can be removed.
>
> Cleans up cppcheck warning:
> drivers/net/hamradio/mkiss.c:220: (warning) Identical inner 'if'
> condition is always true.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Applied.