Re: [PATCH] media: mxl5xx: fix get_algo()'s return type

From: Daniel Scheller
Date: Tue Apr 24 2018 - 13:21:24 EST


Am Tue, 24 Apr 2018 15:19:31 +0200
schrieb Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>:

> The method dvb_frontend_ops::get_frontend_algo() is defined as
> returning an 'enum dvbfe_algo', but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'enum dvbfe_algo' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
> ---
> drivers/media/dvb-frontends/mxl5xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-frontends/mxl5xx.c b/drivers/media/dvb-frontends/mxl5xx.c
> index 483ee7d61..274d8fca0 100644
> --- a/drivers/media/dvb-frontends/mxl5xx.c
> +++ b/drivers/media/dvb-frontends/mxl5xx.c
> @@ -375,7 +375,7 @@ static void release(struct dvb_frontend *fe)
> kfree(state);
> }
>
> -static int get_algo(struct dvb_frontend *fe)
> +static enum dvbfe_algo get_algo(struct dvb_frontend *fe)
> {
> return DVBFE_ALGO_HW;
> }

Acked-by: Daniel Scheller <d.scheller@xxxxxxx>

Best regards,
Daniel Scheller
--
https://github.com/herrnst