Re: [net-next 1/2] ipv6: sr: add a per namespace sysctl to control seg6 flowlabel

From: David Miller
Date: Tue Apr 24 2018 - 13:17:00 EST


From: Ahmed Abdelsalam <amsalam20@xxxxxxxxx>
Date: Mon, 23 Apr 2018 23:36:59 +0200

> This patch adds a per namespace sysctl, named 'seg6_flowlabel', to be used
> by seg6_do_srh_encap() to control the behaviour of setting the flowlabel
> value of outer IPv6.
>
> The currently support behaviours are as follows:
> -1 set flowlabel to zero.
> 0 copy flowlabel from Inner paceket in case of Inner IPv6 (0 for IPv4/L2)
> 1 Compute the flowlabel using seg6_make_flowlabel()
>
> Signed-off-by: Ahmed Abdelsalam <amsalam20@xxxxxxxxx>

There really isn't a reason to make this a separate patch.

Adding a sysctl that nothing refers to doesn't add much value.

So please combine patches #1 and #2.