Re: [PATCH v5] fs: dax: Adding new return type vm_fault_t

[Matthew Wilcox]

On Tue, Apr 24, 2018 at 11:29:39AM +0530, Souptick Joarder wrote:
> On Tue, Apr 24, 2018 at 1:19 AM, Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
> > On Mon, Apr 23, 2018 at 11:36:25PM +0530, Souptick Joarder wrote:
> >> If the insertion of PTE failed because someone else
> >> already added a different entry in the mean time, we
> >> treat that as success as we assume the same entry was
> >> actually inserted.
> >
> > No, Jan said to *make it a comment*.  In the source file.  That's why
> > he formatted it with the /* */.  Not in the changelog.
> Sorry, got confused.
> 
> I think this should be fine -
> 
> +/*
> +If the insertion of PTE failed because someone else
> +already added a different entry in the mean time, we
> +treat that as success as we assume the same entry was
> +actually inserted.
> +*/

Jan literally typed out exactly what you need to insert:

/*
 * If the insertion of PTE failed because someone else already added a
 * different entry in the mean time, we treat that as success as we assume
 * the same entry was actually inserted.
 */

For some reason you've chosen to wrap the lines shorter than Jan had them,
and use a different comment formatting style from the rest of the kernel.
Why?  I'd suggest re-reading Documentation/process/coding-style.rst