Re: [PATCH v4 1/2] drm/vc4: Add CTM support

From: Eric Anholt
Date: Mon Apr 23 2018 - 14:54:59 EST


Stefan Schake <stschake@xxxxxxxxx> writes:

> The hardware has a single block for applying a CTM prior to gamma lut.
> It can be fed with pixels from one of our CRTC at a time and uses a
> matrix with S0.9 scalars. Use private atomic state to reject attempts
> from userland to apply CTM for more than one CRTC at a time and reject
> matrices with scalars that we can't approximate without integer bits.

Looks good! I think you got all the transition cases we were concerned
about before.

Reviewed and applied these two to drm-misc-next. Thanks!

Attachment: signature.asc
Description: PGP signature