Re: [PATCH] KVM: s390: reset crypto attributes for all vcpus

[Halil Pasic]

On 04/22/2018 05:06 PM, Tony Krowiak wrote:
> OnÂ04/20/2018Â08:26ÂAM,ÂDavidÂHildenbrandÂwrote:
> > OnÂ19.04.2018Â23:13,ÂTonyÂKrowiakÂwrote:
> > > IntroducesÂaÂnewÂfunctionÂtoÂresetÂtheÂcryptoÂattributesÂforÂall
> > > vcpusÂwhetherÂtheyÂareÂrunningÂorÂnot.ÂEachÂvcpuÂinÂKVMÂwill
> > > beÂremovedÂfromÂSIEÂpriorÂtoÂresettingÂtheÂcryptoÂattributesÂinÂits
> > > SIEÂstateÂdescription.ÂAfterÂallÂvcpusÂhaveÂhadÂtheirÂcryptoÂattributes
> > > resetÂtheÂvcpusÂwillÂbeÂrestoredÂtoÂSIE.
> > >
> > > ThisÂfunctionÂisÂincorporatedÂintoÂtheÂkvm_s390_vm_set_crypto(kvm)
> > > functionÂtoÂfixÂaÂreportedÂissueÂwherebyÂtheÂcryptoÂkeyÂwrapping
> > > attributesÂcouldÂpotentiallyÂgetÂoutÂofÂsynchÂforÂrunningÂvcpus.
> > >
> > > Reported-by:ÂHalilÂPasic <pasic@xxxxxxxxxxxxxxxxxx>
> > AÂreported-byÂforÂaÂcodeÂrefactoringÂisÂstrange.
>
> IÂwasÂaskedÂtoÂincludeÂthis.

Is this a refactoring or a fix? I the message you state that you are
fixing an issue (aka bug). If you are not, fixing an issue, but indeed
just refactoring, Suggested-by would be more appropriate.

Regards,
Halil