Re: [PATCH 1/4] lan78xx: Read MAC address from DT if present

From: Andrew Lunn
Date: Thu Apr 12 2018 - 10:06:58 EST


Hi Phil

> - ret = lan78xx_write_reg(dev, RX_ADDRL, addr_lo);
> - ret = lan78xx_write_reg(dev, RX_ADDRH, addr_hi);
> + mac_addr = of_get_mac_address(dev->udev->dev.of_node);

It might be better to use the higher level eth_platform_get_mac_address().

Andrew