Re: [Xen-devel] [PATCH] x86/xen: zero MSR_IA32_SPEC_CTRL before suspend

From: Ingo Molnar
Date: Thu Apr 12 2018 - 04:08:53 EST



* Jan Beulich <JBeulich@xxxxxxxx> wrote:

> >>> On 12.04.18 at 09:32, <mingo@xxxxxxxxxx> wrote:
>
> > * Jan Beulich <JBeulich@xxxxxxxx> wrote:
> >
> >> >>> On 11.04.18 at 13:53, <mingo@xxxxxxxxxx> wrote:
> >> > * Jan Beulich <JBeulich@xxxxxxxx> wrote:
> >> >
> >> >> Additionally, x86 maintainers: is there a particular reason this (or
> >> >> any functionally equivalent patch) isn't upstream yet? As indicated
> >> >> before, I had not been able to find any discussion, and hence I
> >> >> see no reason why this is a patch we effectively carry privately in
> >> >> our distro branches (and likely other distros do so too).
> >> >
> >> > The patch was merged 6 weeks ago and is now upstream:
> >> >
> >> > 71c208dd54ab: x86/xen: Zero MSR_IA32_SPEC_CTRL before suspend
> >>
> >> I'm sorry, but no, this isn't the patch I was inquiring about.
> >> Instead I'm wondering of the disposition of the patch disabling
> >> IBRS around a CPU going idle.
> >
> > Got any specific link or subject line for that submission?
>
> Sure, as written in the original response to Jürgen's patch:
> https://patchwork.kernel.org/patch/10153843/

Argh, indeed you did!

In any case, this submission from Tim Chen:

[PATCH v3 0/5] IBRS patch series

Contained a glaring bug in patch #2 which Thomas pointed out, and AFAICS the
series was never resubmitted to lkml so it got lost.

In any case thanks for the reminder!

Thanks,

Ingo