Re: [PATCH] lan78xx: Don't reset the interface on open

From: David Miller
Date: Wed Apr 11 2018 - 14:45:57 EST


From: Phil Elwell <phil@xxxxxxxxxxxxxxx>
Date: Tue, 10 Apr 2018 13:18:25 +0100

> Commit 92571a1aae40 ("lan78xx: Connect phy early") moves the PHY
> initialisation into lan78xx_probe, but lan78xx_open subsequently calls
> lan78xx_reset. As well as forcing a second round of link negotiation,
> this reset frequently prevents the phy interrupt from being generated
> (even though the link is up), rendering the interface unusable.
>
> Fix this issue by removing the lan78xx_reset call from lan78xx_open.
>
> Fixes: 92571a1aae40 ("lan78xx: Connect phy early")
> Signed-off-by: Phil Elwell <phil@xxxxxxxxxxxxxxx>

Applied and queued up for -stable, thanks.