Re: [PATCH] sched/fair: schedutil: update only with all info available

From: Vincent Guittot
Date: Wed Apr 11 2018 - 03:57:55 EST


On 6 April 2018 at 19:28, Patrick Bellasi <patrick.bellasi@xxxxxxx> wrote:

> }
> @@ -5454,8 +5441,11 @@ static void dequeue_task_fair(struct rq *rq, struct task_struct *p, int flags)
> update_cfs_group(se);
> }
>
> - if (!se)
> + /* The task is no more visible from the root cfs_rq */
> + if (!se) {
> sub_nr_running(rq, 1);
> + cpufreq_update_util(rq, 0);

call to cpufreq_update_util() should be done after util_est_dequeue()

> + }
>
> util_est_dequeue(&rq->cfs, p, task_sleep);
> hrtick_update(rq);