Re: [PATCH v2 2/3] microblaze: remove redundant early_printk support

From: Michal Simek
Date: Tue Apr 10 2018 - 09:45:23 EST


Hi Rob,

On 28.3.2018 04:06, Rob Herring wrote:
> With earlycon support now enabled, the arch specific early_printk support
> can be removed.

earlycon is not the full replacement of early_printk support as is
designed right now.
Definitely current early_printk is pretty old and contains code
duplication but it starts much earlier then earlycon.

>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> Cc: Michal Simek <monstr@xxxxxxxxx>
> ---
> v2:
> - Fix booting. The setup_memory call needed to be before the
> parse_early_param call.

What's the reason for calling setup_memory before parse_early_param?
Is there any dependency?

Thanks,
Michal