Re: [PATCH 4/9] x86, pkeys: override pkey when moving away from PROT_EXEC

From: Dave Hansen
Date: Fri Mar 23 2018 - 15:30:23 EST


On 03/23/2018 12:27 PM, Shakeel Butt wrote:
> On Fri, Mar 23, 2018 at 12:23 PM, Dave Hansen <dave.hansen@xxxxxxxxx> wrote:
>> On 03/23/2018 12:15 PM, Shakeel Butt wrote:
>>>> We had a check for PROT_READ/WRITE, but it did not work
>>>> for PROT_NONE. This entirely removes the PROT_* checks,
>>>> which ensures that PROT_NONE now works.
>>>>
>>>> Reported-by: Shakeel Butt <shakeelb@xxxxxxxxxx>
>>>> Signed-off-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
>>> Should there be a 'Fixes' tag? Also should this patch go to stable?
>> There could be, but I'm to lazy to dig up the original commit. Does it
>> matter?
>>
> I think for stable 'Fixes' is usually preferable.

This one is a no-brainer. If pkeys.c is there, it's necesary.