Re: [PATCH] crypto: ctr: avoid VLA use

[Salvatore Mesoraca]

2018-03-14 14:31 GMT+01:00 Stephan Mueller <smueller@xxxxxxxxxx>:
> Am Mittwoch, 14. MÃrz 2018, 14:17:30 CET schrieb Salvatore Mesoraca:
>
> Hi Salvatore,
>
>>       if (walk.nbytes) {
>> -             crypto_ctr_crypt_final(&walk, child);
>> -             err = blkcipher_walk_done(desc, &walk, 0);
>> +             err = crypto_ctr_crypt_final(&walk, child);
>> +             err = blkcipher_walk_done(desc, &walk, err);
>
> I guess you either want to handle the error from crypto_ctr_crypt_final or do
> an err |= blkcipher_walk_done.

I think that blkcipher_walk_done handles and returns the error for me.
Am I wrong?

Best regards,

Salvatore