Re: [PATCH] staging:r8188eu: use lib80211 CCMP decrypt

[Ivan Safonov]

On 02/26/2018 10:56 AM, Dan Carpenter wrote:
> On Fri, Feb 23, 2018 at 05:57:42PM +0300, Ivan Safonov wrote:
> > Custom AES decrypt implementation replaced with lib80211 library.
> >
> > Signed-off-by: Ivan Safonov <insafonov@xxxxxxxxx>
>
> The new code looks like original RTL code (really bad) so I'm guessing
> you copy and pasted the code from somewhere else?
Unfortunately, your assumption is wrong. Rather, bad code is created 
because I'm not a good programmer =).

Seriously, after each patch the driver gets better, does not it?

> The idea is good, but RTL code is painful to look at.
The basic idea is to replace a _small_ (or trivial) parts of the 
program, because I can not test my patches.

> regards,
> dan carpenter

Ivan Safonov.