Re: [PATCH v2 2/2] fs/sysctl: remove redundant link check in proc_sys_link_fill_cache()

From: Luis R. Rodriguez
Date: Tue Feb 27 2018 - 20:16:05 EST


On Tue, Feb 27, 2018 at 03:41:40PM -0800, Kees Cook wrote:
> On Tue, Feb 27, 2018 at 3:31 PM, Danilo Krummrich
> <danilokrummrich@xxxxxxxxxxxxx> wrote:
> > proc_sys_link_fill_cache() does not need to check whether we're
> > called for a link - it's already done by scan().
> >
> > Signed-off-by: Danilo Krummrich <danilokrummrich@xxxxxxxxxxxxx>
>
> Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
>
> > ---
> > v2: removed 'err' as it's only used for sysctl_follow_link()
>
> Thanks :)
>
> Luis, do you have a tree for sysctl, or should these just go via -mm?

-mm has been working beautifully so far.

Now that acks have been collected, Danilo, can you also add the other tags
mentioned and resubmit and add akpm@xxxxxxxxxxxxxxxxxxxx ?

Luis