Re: [PATCH] x86/mm/sme: Disable stack protection for mem_encrypt_identity.c

From: Kirill A. Shutemov
Date: Tue Feb 27 2018 - 10:43:27 EST


On Mon, Feb 26, 2018 at 05:25:54PM -0600, Tom Lendacky wrote:
> Stack protection is not compatible with early boot code. All of the early
> SME boot code is now isolated in a separate file, mem_encrypt_identity.c,
> so arch/x86/mm/Makefile can be updated to turn off stack protection for
> the entire file. This eliminates the need to worry about other functions
> within the file being instrumented with stack protection (as was seen
> when a newer version of GCC instrumented sme_encrypt_kernel() where an
> older version hadn't). It also allows removal of the __nostackprotector
> attribute from individual functions.
>
> Signed-off-by: Tom Lendacky <thomas.lendacky@xxxxxxx>

Looks good to me.

Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

--
Kirill A. Shutemov