Re: [PATCH v3 3/8] mfd: cros_ec: Don't try to grab log when suspended

From: Benson Leung
Date: Tue Feb 27 2018 - 01:47:46 EST


Hi Enric,

Thanks for sending this.

On Mon, Feb 26, 2018 at 11:26:01AM +0100, Enric Balletbo i Serra wrote:
> From: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
> We should stop our worker thread while we're suspended. If we don't
> then we'll get messages like:
>
> cros-ec-spi spi5.0: spi transfer failed: -108
> cros-ec-spi spi5.0: cs-deassert spi transfer failed: -108
> cros-ec-ctl cros-ec-ctl.0.auto: EC communication failed
>
> Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> ---
>
> Changes in v3:
> - [3/8] Add Reviewed-by Andy Shevchenko.
>
> Changes in v2:
> - [3/8] That patch is new in this series.
>
> drivers/mfd/cros_ec_dev.c | 4 ++++
> drivers/platform/chrome/cros_ec_debugfs.c | 20 ++++++++++++++++++++
> include/linux/mfd/cros_ec.h | 2 ++

Looks like this will need an immutable branch between mfd and chrome-platform
again, Lee.

Do you want to do one, or should I?

Thanks,
Benson


--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@xxxxxxxxxx
Chromium OS Project
bleung@xxxxxxxxxxxx

Attachment: signature.asc
Description: PGP signature