Re: [PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert

From: Bart Van Assche
Date: Tue Feb 27 2018 - 00:12:49 EST


On Tue, 2018-02-27 at 12:00 +0800, jianchao.wang wrote:
> On the other hand, this patch is to align the actions between blk-mq and block
> legacy code in __scsi_queue_insert.

Hello Jianchao,

Since the legacy SCSI core unpreps an reprepares a request when requeuing it I
think your patch does not align the blk-mq and legacy block layer actions but
instead makes the behavior of the two code paths different.

Thanks,

Bart.