Re: [PATCH v3] rtc: cros-ec: return -ETIME when refused to set alarms in the past

From: JeffyChen
Date: Mon Feb 26 2018 - 21:53:23 EST


Hi guys,

On 02/27/2018 10:47 AM, Jeffy Chen wrote:
/* Don't set an alarm in the past. */
if ((u32)alarm_time < current_time)
Oops, i'm a idiot, forgot to use '<='... will resend it.
- alarm_offset = EC_RTC_ALARM_CLEAR;
- else
- alarm_offset = (u32)alarm_time - current_time;
+ return -ETIME;
+
+ alarm_offset = (u32)alarm_time - current_time;
}