Re: [PATCH 2/7] genalloc: selftest

From: J Freyensee
Date: Mon Feb 26 2018 - 12:46:53 EST




On 2/26/18 4:11 AM, Igor Stoppa wrote:

On 24/02/18 00:42, J Freyensee wrote:
+ locations[action->location] = gen_pool_alloc(pool, action->size);
+ BUG_ON(!locations[action->location]);
Again, I'd think it through if you really want to use BUG_ON() or not:

https://lwn.net/Articles/13183/
https://lkml.org/lkml/2016/10/4/1
Is it acceptable to display only a WARNing, in case of risking damaging
a mounted filesystem?

That's a good question. Based upon those articles, 'yes'. But it seems like a 'darned-if-you-do, darned-if-you-don't' question as couldn't you also corrupt a mounted filesystem by crashing the kernel, yes/no?

If you really want a system crash, maybe just do a panic() like filesystems also use?

--
igor