Re: [PATCH 1/2] selftests: ion: Remove some prints

From: Shuah Khan
Date: Mon Feb 26 2018 - 11:55:01 EST


On 02/15/2018 06:24 PM, Laura Abbott wrote:
> There's no need to print messages each time we alloc and free. Remove them.
>
> Signed-off-by: Laura Abbott <labbott@xxxxxxxxxx>
> ---
> tools/testing/selftests/android/ion/ionutils.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/tools/testing/selftests/android/ion/ionutils.c b/tools/testing/selftests/android/ion/ionutils.c
> index ce69c14f51fa..7d1d37c4ef6a 100644
> --- a/tools/testing/selftests/android/ion/ionutils.c
> +++ b/tools/testing/selftests/android/ion/ionutils.c
> @@ -80,11 +80,6 @@ int ion_export_buffer_fd(struct ion_buffer_info *ion_info)
> heap_id = MAX_HEAP_COUNT + 1;
> for (i = 0; i < query.cnt; i++) {
> if (heap_data[i].type == ion_info->heap_type) {
> - printf("--------------------------------------\n");
> - printf("heap type: %d\n", heap_data[i].type);
> - printf(" heap id: %d\n", heap_data[i].heap_id);
> - printf("heap name: %s\n", heap_data[i].name);
> - printf("--------------------------------------\n");
> heap_id = heap_data[i].heap_id;
> break;
> }
> @@ -204,7 +199,6 @@ void ion_close_buffer_fd(struct ion_buffer_info *ion_info)
> /* Finally, close the client fd */
> if (ion_info->ionfd > 0)
> close(ion_info->ionfd);
> - printf("<%s>: buffer release successfully....\n", __func__);
> }
> }
>
>
Thanks Laura. I will queue this up for 4.17-rc1.

thanks,
-- Shuah