Re: [PATCH] Revert "gpio: winbond: fix ISA_BUS_API dependency"

From: Arnd Bergmann
Date: Fri Feb 23 2018 - 10:19:08 EST


On Fri, Feb 23, 2018 at 3:55 PM, Maciej S. Szmigiero
<mail@xxxxxxxxxxxxxxxxxxxxx> wrote:
> This reverts commit 92a8046c9d952a2a7d21dfcd3afadc72a0bc0f72.
>
> Now that the patch series changing ISA_BUS_API dependency to selection
> was merged this reversion will do the same for gpio-winbond driver to
> make it consistent with other ISA bus gpio drivers.
>
> Signed-off-by: Maciej S. Szmigiero <mail@xxxxxxxxxxxxxxxxxxxxx>

I still see a number of other users of 'depends on ISA_BUS_API' in linux-next:

drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
drivers/gpio/Kconfig: depends on PC104 && ISA_BUS_API
drivers/gpio/Kconfig: depends on ISA_BUS_API
drivers/gpio/Kconfig: depends on ISA_BUS_API
drivers/iio/adc/Kconfig: depends on PC104 && X86 && ISA_BUS_API
drivers/iio/counter/Kconfig: depends on PC104 && X86 && ISA_BUS_API
drivers/iio/dac/Kconfig: depends on X86 && ISA_BUS_API
drivers/watchdog/Kconfig: depends on X86 && ISA_BUS_API

Did you change all of the above? I would really like to avoid mixing
'select' and 'depends on' here, as that will likely cause other circular
dependencies in the future.

Arnd