Re: [PATCH] perf annotate: Support to display the LBR data in tui mode

From: Jin, Yao
Date: Fri Feb 23 2018 - 04:09:06 EST




On 2/23/2018 4:25 PM, Peter Zijlstra wrote:
On Fri, Feb 23, 2018 at 10:35:58PM +0800, Jin Yao wrote:
Unlike the perf report interactive annotate mode, the perf annotate
doesn't display the LBR data.

perf record -b ...
perf annotate function

It should show IPC/cycle, but it doesn't.

There is far more than IPC/cycle for the LBR data, so this Changelog is
misleading.


I will change the changelog to make it more clear.

Also, I think that this patch goes the wrong way, we should reduce the
divergence of the various modes, not make it worse.

I do plan to support stdio mode. While stdio mode needs more changes than tui mode, so I plan to do it in a follow-up patch.

Posting this patch now is because I want to listen from community first for this feature. If the tui patch could be accepted, then it's worth putting more efforts on stdio version. That's my thoughts.

Thanks
Jin Yao