Re: [PATCH v2] [media] Delete unnecessary variable initialisations in seven functions

From: Alexey Klimov
Date: Thu Feb 22 2018 - 20:06:23 EST


On Thu, Feb 22, 2018 at 9:22 PM, SF Markus Elfring
<elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 22 Feb 2018 21:45:47 +0100
>
> Some local variables will be set to an appropriate value before usage.
> Thus omit explicit initialisations at the beginning of these functions.
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> ---
>
> v2:
> Hans Verkuil insisted on patch squashing. Thus some changes
> were recombined based on source files from Linux next-20180216.
>
> drivers/media/radio/radio-mr800.c | 2 +-

For radio-mr800:

Acked-by: Alexey Klimov <klimov.linux@xxxxxxxxx>

> drivers/media/radio/radio-wl1273.c | 2 +-
> drivers/media/radio/si470x/radio-si470x-usb.c | 2 +-
> drivers/media/usb/cx231xx/cx231xx-cards.c | 2 +-
> drivers/media/usb/cx231xx/cx231xx-dvb.c | 2 +-
> drivers/media/usb/go7007/snd-go7007.c | 2 +-
> drivers/media/usb/tm6000/tm6000-cards.c | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/media/radio/radio-mr800.c b/drivers/media/radio/radio-mr800.c
> index dc6c4f985911..0f292c6ba338 100644
> --- a/drivers/media/radio/radio-mr800.c
> +++ b/drivers/media/radio/radio-mr800.c
> @@ -511,5 +511,5 @@ static int usb_amradio_probe(struct usb_interface *intf,
> const struct usb_device_id *id)
> {
> struct amradio_device *radio;
> - int retval = 0;
> + int retval;
>
> diff --git a/drivers/media/radio/radio-wl1273.c b/drivers/media/radio/radio-wl1273.c

[..]

Thanks!
Alexey