Re: [PATCH 1/2] mfd: arizona: Update reset pin to use GPIOD

From: Linus Walleij
Date: Thu Feb 22 2018 - 09:47:02 EST


On Wed, Feb 14, 2018 at 4:55 PM, Charles Keepax
<ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote:

> Now GPIOD has support for both pdata systems and for non-standard DT
> bindings the Arizona reset GPIO can be converted to use it.
>
> Signed-off-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
(...)
> + pdata->reset = devm_gpiod_get_from_of_node(arizona->dev,
> + arizona->dev->of_node,
> + "wlf,reset", 0,
> + GPIOD_OUT_LOW,
> + "arizona /RESET");

It seems this call is really useful.

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Also thanks for testing this API, I had nothing to test it on...

Yours,
Linus Walleij