Re: [PATCH 05/10] dt-bindings: gpio: Add gpio nodes for Actions S900 SoC

From: Rob Herring
Date: Wed Feb 21 2018 - 18:52:52 EST


On Wed, Feb 21, 2018 at 8:58 AM, Manivannan Sadhasivam
<manivannan.sadhasivam@xxxxxxxxxx> wrote:
> Hi Rob,
> On Mon, Feb 19, 2018 at 02:35:23PM -0600, Rob Herring wrote:
>> On Sun, Feb 18, 2018 at 02:14:28AM +0530, Manivannan Sadhasivam wrote:
>> > Add gpio nodes for Actions Semi S900 SoC.
>> >
>> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
>> > ---
>> > .../devicetree/bindings/gpio/actions,owl-gpio.txt | 15 +++++++++++++++
>> > 1 file changed, 15 insertions(+)
>> > create mode 100644 Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
>> >
>> > diff --git a/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
>> > new file mode 100644
>> > index 000000000000..4cd4cb7bfd1b
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt
>> > @@ -0,0 +1,15 @@
>> > +* Actions Semi OWL GPIO controller bindings
>> > +
>> > +- compatible : Should be "actions,s900-gpio"
>> > +- reg : Address and range of the GPIO controller registers.
>> > +- gpio-controller : Marks the device node as a GPIO controller.
>> > +- #gpio-cells : Should be <2>. The first cell is the gpio number and
>> > + the second cell is used to specify optional parameters.
>>
>> Doesn't do interrupts?
>>
> Interrupt support will be added once this base driver gets in.
> One step at a time ;-)

Binding are separate from the driver. Drivers can evolve, but h/w
doesn't (for a given piece of Si). It is not a high bar to list
#interrupt-cells and interrupt-controller.

Rob