Re: [PATCH 3/6] mfd: cros_ec_dev: Register cros-ec-rtc driver as a subdevice.

[Gwendal Grignou]

On Mon, Feb 19, 2018 at 2:40 PM, Enric Balletbo i Serra
<enric.balletbo@xxxxxxxxxxxxx> wrote:
> Check whether this EC instance has RTC host command support and instatiate
> the RTC driver as a subdevice in such case.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
Reviewed-by: Gwendal Grignou <gwendal@xxxxxxxxxxxx>
> ---
>  drivers/mfd/cros_ec_dev.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index e4fafdd96e5e..e0c604ab380f 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -389,6 +389,10 @@ static void cros_ec_sensors_register(struct cros_ec_dev *ec)
>         kfree(msg);
>  }
>
> +static const struct mfd_cell cros_ec_rtc_cell = {
> +       .name = "cros-ec-rtc",

> +};
> +
>  static int ec_device_probe(struct platform_device *pdev)
>  {
>         int retval = -ENOMEM;
> @@ -437,6 +441,16 @@ static int ec_device_probe(struct platform_device *pdev)
>         if (cros_ec_check_features(ec, EC_FEATURE_MOTION_SENSE))
>                 cros_ec_sensors_register(ec);
>
> +       /* check whether this EC instance has RTC host command support */
> +       if (cros_ec_check_features(ec, EC_FEATURE_RTC)) {
> +               retval = mfd_add_devices(ec->dev, PLATFORM_DEVID_AUTO,
> +                                        &cros_ec_rtc_cell, 1, NULL, 0, NULL);
> +               if (retval)
> +                       dev_err(ec->dev,
> +                               "failed to add cros-ec-rtc device: %d\n",
> +                               retval);
> +       }
> +
>         /* Take control of the lightbar from the EC. */
>         lb_manual_suspend_ctrl(ec, 1);
>
> --
> 2.16.1
>