Re: [PATCH v2 08/10] gpio: Add gpio driver for Actions OWL S900 SoC

[Andreas FÃrber]

Am 21.02.2018 um 20:13 schrieb Andy Shevchenko:
> On Wed, Feb 21, 2018 at 6:00 PM, Manivannan Sadhasivam
> <manivannan.sadhasivam@xxxxxxxxxx> wrote:
>> Add gpio driver for Actions Semi OWL family S900 SoC. Set of registers
>> controlling the gpio shares the same register range with pinctrl block.
>>
>> GPIO registers are organized as 6 banks and each bank controls the
>> maximum of 32 gpios.
> 
>> +static void owl_gpio_set_reg(void __iomem *base, unsigned int pin, int flag)
>> +{
>> +       u32 val;
>> +
>> +       if (flag) {
>> +               val = readl(base);
>> +               val |= BIT(pin);
>> +               writel(val, base);
>> +       } else {
>> +               val = readl(base);
>> +               val &= ~BIT(pin);
>> +               writel(val, base);
>> +       }
>> +}
> 
> Why not to use the same pattern as below?
> 
> readl()
> if ()
>  ...
> else
> ...
> writel()
> 
> ?

And shouldn't that be readl_relaxed() and writel_relaxed()?

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Felix ImendÃrffer, Jane Smithard, Graham Norton
HRB 21284 (AG NÃrnberg)