Re: [PATCH v4 2/2] ptrace, seccomp: add support for retrieving seccomp metadata

From: Tycho Andersen
Date: Tue Feb 20 2018 - 21:49:37 EST


On Tue, Feb 20, 2018 at 10:30:52PM +0300, Dmitry V. Levin wrote:
> > +struct seccomp_metadata {
> > + unsigned long filter_off; /* Input: which filter */
> > + unsigned int flags; /* Output: filter's flags */
> > +};
>
> This "unsigned long" field is unacceptable unless you are willing
> to implement a compat layer for this arch-dependent type.
>
> Please use an arch-independent type instead.
> See e.g. struct ptrace_peeksiginfo_args or struct struct seccomp_data.

Whoops, sorry about that. I believe I've addressed it in
https://lkml.org/lkml/2018/2/20/755

Cheers,

Tycho