Re: [PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

From: Philippe Ombredanne
Date: Tue Feb 20 2018 - 02:46:34 EST


Hi Moritz,

On Fri, Feb 16, 2018 at 6:00 PM, Moritz Fischer <mdf@xxxxxxxxxx> wrote:
> Add support for the National Instruments XGE 1/10G network device.
>
> It uses the EEPROM on the board via NVMEM.
>
> Signed-off-by: Moritz Fischer <mdf@xxxxxxxxxx>

<snip>

> --- /dev/null
> +++ b/drivers/net/ethernet/ni/nixge.c
> @@ -0,0 +1,1352 @@
> +// SPDX-License-Identifier: GPL-2.0

<snip>

> +MODULE_LICENSE("GPL");

This does not match your license above. Per module.h "GPL" would mean "GPL-2.0+"
Can you use one or the other an\d ensure both of these are in sync?

--
Cordially
Philippe Ombredanne