Re: [PATCH v3] ACPI / tables: Add IORT to injectable table list

From: Yang, Shunyong
Date: Mon Feb 19 2018 - 21:53:46 EST


Hi, Jon,

On Mon, 2018-02-19 at 14:13 -0500, Jon Masters wrote:
> On 02/02/2018 07:12 AM, Wang, Dongsheng wrote:
> >
> > Hey, Hanjun,
> >
> > On 2018/2/2 19:54:24, "Hanjun Guo" <guohanjun@xxxxxxxxxx> wrote:
> >
> > >
> > > On 2018/2/2 18:25, Yang Shunyong wrote:
> > > >
> > > > Loading IORT table from initrd is used to fix firmware IORT
> > > > defects.
> > > I don't think this fix "firmware defects", it just for debug
> > > purpose,
> > > we will not use that for production purpose, right? I think above
> > > line
> > > can be removed.
> > >
> > I thinks the upgrade feature not only for debug. Here's an
> > important
> > way to fix bugs that come from the firmware.
> >
> > Documentation/acpi/initrd_table_override.txt
> I think we should message that this is for debug/development use.
> Ultimately, it's not the way to address firmware problems. Firmware
> needs to address that by shipping the correct(ed) tables :)

Thanks for your feedback.
According to following description in
Documentation/acpi/initrd_table_override.txt
"Complain to your platform/BIOS vendor if you find a bug which is so
severe that a workaround is not accepted in the Linux kernel. And this
facility allows you to upgrade the buggy tables before your
platform/BIOS vendor releases an upgraded BIOS binary."

I have changed the commit message to "Loading IORT table from initrd
can be used to fix severe firmware
IORT defects temporarily before platform/BIOS vendor releases an
upgraded BIOS binary..." in v4.

Detail Link is here,
https://patchwork.kernel.org/patch/10202391/

Thanks.
Shunyong.