Re: [PATCH] objtool/x86: Replace Non-standard Range Expression in Case

[Josh Poimboeuf]

On Fri, Feb 16, 2018 at 08:09:24PM +0530, Progyan Bhattacharya wrote:
> Replace range expressions with seperate individual cases, i.e. convert case 1...3: to case 1: case 2: case 3
> Range expression within case statements are non-standard C code and can create issues over compiler and platform variety.
> 
> While compiling with gcc 4.8 (RHEL) I encountered this error on range expression in case statements:
> error: range expressions in switch statements are non-standard [-Werror=pedantic]
> 
> Signed-off-by: Progyan Bhattacharya <progyanb@xxxxxxx>

Progyan,

Please try to be respectful of reviewers' time by

  a) running scripts/checkpatch.pl and closely reviewing your patch
     before sending;

  b) not sending multiple revisions in a single day;

  c) when sending a new revision, add the version number in the subject
     line and clarify what has changed.


I'd also recommend reviewing the following resources:

  - https://www.youtube.com/watch?v=-3HNeoFuSH0

  - Documentation/process/submitting-patches.rst

-- 
Josh