Re: [PATCH 1/2] lightnvm: remove mlc pairs structure

[Javier GonzÃlez]

> On 31 Jan 2018, at 16.35, Matias BjÃrling <mb@xxxxxxxxxxx> wrote:
> 
> On 01/31/2018 03:00 AM, Javier GonzÃlez wrote:
>>> On 30 Jan 2018, at 21.26, Matias BjÃrling <m@xxxxxxxxxxx> wrote:
>>> 
>>> The known implementations of the 1.2 specification, and upcoming 2.0
>>> implementation all expose a sequential list of pages to write.
>>> Remove the data structure, as it is no longer needed.
>>> 
>>> Signed-off-by: Matias BjÃrling <m@xxxxxxxxxxx>
>>> ---
>>> drivers/nvme/host/lightnvm.c | 14 +-------------
>>> 1 file changed, 1 insertion(+), 13 deletions(-)
>> Even though the current implementations does not use the MLC pairing
>> information, this is part of the on the 1.2 identification. Until we
>> eventually remove 1.2 support (if we do), the identify structure should
>> reflect the specification as is.
>> Javier
> 
> I already started on removing the MLC bits in previous patches. These
> two patches continue that trend. I don't know of any implementing
> either multiple groups or MLC, and since it has not been implemented
> before, no one is going to use it. No reason to have dead code hanging
> around. This is similar to the NVMe device driver not having
> definitions for all that is in the specification until it is used in
> the implementation.

It's ok with me - just wanted to point out that it seems weird removing
bits from the structure that describes the 1.2 identify command. Guess
these can com back if someone ever needs them...

Javier

Attachment: signature.asc
Description: Message signed with OpenPGP