Re: [PATCH v2] mm/swap.c: make functions and their kernel-doc agree

From: Matthew Wilcox
Date: Wed Jan 31 2018 - 02:58:56 EST


On Tue, Jan 30, 2018 at 01:34:00PM +0100, Michal Hocko wrote:
> On Mon 29-01-18 16:43:55, Randy Dunlap wrote:
> > - for function pagevec_lookup_entries(), change the function parameter
> > name from nr_pages to nr_entries since that is more descriptive of
> > what the parameter actually is and then it matches the kernel-doc
> > comments also
>
> I know what is nr_pages because I do expect pages to be returned. What
> are entries? Can it be something different from pages?

entries are any page cache entries -- pages or exceptional entries.
calling this parameter nr_pages tricks you into thinking that you'll
only get pages back.