Re: [PATCH v2 3/3] KVM: VMX: make MSR bitmaps per-VCPU

From: David Hildenbrand
Date: Mon Jan 29 2018 - 05:36:06 EST


On 27.01.2018 09:50, Paolo Bonzini wrote:
> Place the MSR bitmap in struct loaded_vmcs, and update it in place
> every time the x2apic or APICv state can change. This is rare and
> the loop can handle 64 MSRs per iteration, in a similar fashion as
> nested_vmx_prepare_msr_bitmap.
>
> This prepares for choosing, on a per-VM basis, whether to intercept
> the SPEC_CTRL and PRED_CMD MSRs.
>
> Suggested-by: Jim Mattson <jmattson@xxxxxxxxxx>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> ---

I really like this change and didn't spot anything obvious.

Acked-by: David Hildenbrand <david@xxxxxxxxxx>


--

Thanks,

David / dhildenb