Re: [PATCH v2 1/2] x86/acpi: add retrieval function for rsdp address

From: Andy Shevchenko
Date: Sun Jan 28 2018 - 10:05:13 EST


On Fri, Jan 26, 2018 at 8:21 PM, Juergen Gross <jgross@xxxxxxxx> wrote:
> On 26/01/18 19:08, Andy Shevchenko wrote:
>> On Thu, Jan 25, 2018 at 4:36 PM, Juergen Gross <jgross@xxxxxxxx> wrote:
>>> Add a function to get the address of the RSDP table. Per default use a
>>> __weak annotated function being a nop.
>>
>> The problem with weak functions that we can't have more than one
>> implementation per kernel while we would like to built several code
>> paths.
>>
>> I have stumbled on the similar stuff and realize that.
>>
>> Perhaps, one of the solution is to have an additional struct under
>> x86_init to alternate ACPI related stuff.
>
> I think we can go that route when another user of that interface is
> appearing.

Why not to establish the struct? At least this route I would like to
go with [1].

[1]: https://lkml.org/lkml/2018/1/17/834

--
With Best Regards,
Andy Shevchenko