Re: [PATCH V4 5/5] regulator: add PM suspend and resume hooks

From: kbuild test robot
Date: Thu Jan 25 2018 - 15:22:20 EST


Hi Chunyan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.15-rc9]
[cannot apply to regulator/for-next next-20180119]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Chunyan-Zhang/bindings-regulator-added-support-for-suspend-states/20180126-024941
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: i386-randconfig-s0-201803 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

drivers//regulator/core.c: In function 'regulator_suspend_late':
>> drivers//regulator/core.c:4319:26: error: 'pm_suspend_target_state' undeclared (first use in this function)
suspend_state_t state = pm_suspend_target_state;
^~~~~~~~~~~~~~~~~~~~~~~
drivers//regulator/core.c:4319:26: note: each undeclared identifier is reported only once for each function it appears in
drivers//regulator/core.c: In function 'regulator_resume_early':
drivers//regulator/core.c:4349:26: error: 'pm_suspend_target_state' undeclared (first use in this function)
suspend_state_t state = pm_suspend_target_state;
^~~~~~~~~~~~~~~~~~~~~~~

vim +/pm_suspend_target_state +4319 drivers//regulator/core.c

4310
4311 /**
4312 * regulator_suspend_late - prepare regulators for system wide suspend
4313 * @state: system suspend state
4314 *
4315 * Configure each regulator with it's suspend operating parameters for state.
4316 */
4317 static int regulator_suspend_late(struct device *dev)
4318 {
> 4319 suspend_state_t state = pm_suspend_target_state;
4320
4321 return class_for_each_device(&regulator_class, NULL, &state,
4322 _regulator_suspend_late);
4323 }
4324 static int _regulator_resume_early(struct device *dev, void *data)
4325 {
4326 int ret = 0;
4327 struct regulator_dev *rdev = dev_to_rdev(dev);
4328 suspend_state_t *state = data;
4329 struct regulator_state *rstate;
4330
4331 rstate = regulator_get_suspend_state(rdev, *state);
4332 if (rstate == NULL)
4333 return -EINVAL;
4334
4335 mutex_lock(&rdev->mutex);
4336
4337 if (rdev->desc->ops->resume_early &&
4338 (rstate->enabled == ENABLE_IN_SUSPEND ||
4339 rstate->enabled == DISABLE_IN_SUSPEND))
4340 ret = rdev->desc->ops->resume_early(rdev);
4341
4342 mutex_unlock(&rdev->mutex);
4343
4344 return ret;
4345 }
4346

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip