Re: [PATCH v5 13/15] livepatch: change to a per-task consistency model

From: Peter Zijlstra
Date: Thu Jan 25 2018 - 07:44:22 EST


On Thu, Jan 25, 2018 at 01:13:21PM +0100, Petr Mladek wrote:
> > What I was getting at, the klp stuff is the very first thing we run when
> > we schedule the idle task, but its placed at the very end of the
> > function. This is confusing.
>
> I see.
>
>
> > The above still doesn't help with solving that. Do you want to run
> > something before we go idle, or before we leave idle, in neither cases
> > would I place it where it is.
>
> In fact, both ways are fine. We require going the idle task
> through the entire cycle anyway. It is because both situations,
> too long idling or non-idling, would block finishing the patch
> transition.
>
> Feel free to move it right before schedule_idle() or
> __current_set_polling().

OK, I'll move it. Thanks!