Re: [PATCH 07/24] x86,vmx: Fix indirect call

From: Peter Zijlstra
Date: Thu Jan 25 2018 - 04:36:39 EST


Subject: x86,vmx: Fix indirect call
From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Date: Tue Jan 23 14:10:19 CET 2018

Replace indirect call with CALL_NOSPEC.

Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
---
- now with THUNK_TARGET()

arch/x86/kvm/vmx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -9129,14 +9129,14 @@ static void vmx_handle_external_intr(str
#endif
"pushf\n\t"
__ASM_SIZE(push) " $%c[cs]\n\t"
- "call *%[entry]\n\t"
+ CALL_NOSPEC
:
#ifdef CONFIG_X86_64
[sp]"=&r"(tmp),
#endif
ASM_CALL_CONSTRAINT
:
- [entry]"r"(entry),
+ THUNK_TARGET(entry),
[ss]"i"(__KERNEL_DS),
[cs]"i"(__KERNEL_CS)
);