Re: [PATCH v1 1/4] seq_file: Introduce DEFINE_SHOW_ATTRIBUTE() helper macro

From: Lee Jones
Date: Wed Jan 24 2018 - 10:12:40 EST


On Wed, 24 Jan 2018, Andy Shevchenko wrote:

> On Tue, 2018-01-23 at 16:05 -0800, Darren Hart wrote:
> > On Tue, Jan 23, 2018 at 09:15:08AM +0000, Lee Jones wrote:
> > > On Mon, 22 Jan 2018, Andy Shevchenko wrote:
> > >
> > > > The DEFINE_SHOW_ATTRIBUTE() helper macro would be useful for
> > > > current
> > > > users, which are many of them, and for new comers to decrease code
> > > > duplication.
> > > >
> > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > > ---
> > > > drivers/mfd/ab8500-debugfs.c | 14 --------------
> > >
> > > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
> >
> > Thanks Andy,
> >
> > Acked-by: Darren Hart (VMware) <dvhart@xxxxxxxxxxxxx>
>
> Just to clarify a bit.
>
> Since the patch series is based on linux-next, the idea is to push it
> and send as second PR to Linus, after others will be ready in mainline.
>
> The rationale is to allow many other current users and perhaps new
> comers, e.g. [1], to utilize it already in the next cycle.

You already have my Ack. Knock yourself out.

> [1]: https://patchwork.kernel.org/patch/10172393/

--
Lee Jones
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog