Re: [PATCH v2] s390: fix handling of -1 in set{,fs}[gu]id16 syscalls

From: Heiko Carstens
Date: Mon Jan 15 2018 - 17:37:09 EST


On Mon, Jan 15, 2018 at 08:38:17PM +0100, Eugene Syromiatnikov wrote:
> For some reason, the implementation of some 16-bit ID system calls
> (namely, setuid16/setgid16 and setfsuid16/setfsgid16) used type cast
> instead of low2highgid/low2highuid macros for converting [GU]IDs, which
> led to incorrect handling of value of -1 (which ought to be considered
> invalid).
>
> Discovered by strace test suite.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Eugene Syromiatnikov <esyr@xxxxxxxxxx>
> ---
> arch/s390/kernel/compat_linux.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks!